[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096374#comment-16096374
 ] 

Daan Hoogland commented on CLOUDSTACK-9542:
-------------------------------------------

the creation of the nics response part is done in two different methods:
- UserVmJoinDaoImpl.newUserVmResponse()
- ApiResponseHelper.createNicResponse()
the first should be calling the second but that would create a package 
dependency issue.

We can do this the easy way and just make the two methods do the same.
Or we can doe this the right way and move the response creation out of the DAO 
implementation.

> listNics API does not return data as per API documentation
> ----------------------------------------------------------
>
>                 Key: CLOUDSTACK-9542
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9542
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: API
>    Affects Versions: 4.5.2, 4.6.2
>         Environment: ACS
>            Reporter: Paul Angus
>            Assignee: Rohit Yadav
>             Fix For: 4.9.2.0, 4.9.1.0, 4.10.1.0
>
>
> Using both Chrome developer tools ans Cloudmonkey to confirm API responses, 
> listNics returns a subset of the NIC information. (as specified in the API 
> documentation)
> {"listnicsresponse":{"count":1,"nic":[{"id":"fbbe345b-6cbd-495f-8e27-d180d782ccbe","networkid":"30002db2-be52-489f-8307-5c2fbcbea374","netmask":"255.255.255.0","gateway":"10.5.1.254","ipaddress":"10.5.1.107","isdefault":true,"macaddress":"06:39:9c:01:0a:5b","deviceid":"0","virtualmachineid":"c65e6c6a-1d9e-4812-89c7-2af2858af76b"}]}}
> However listVirtualMachines does return the full detail.
> {"listvirtualmachinesresponse":{"count":1,"virtualmachine":[{"id":"c65e6c6a-1d9e-4812-89c7-2af2858af76b","name":"sbjenkins-cattle1","displayname":"sbjenkins-cattle1","account":"ryadav","domainid":"5dfaa086-6a9c-11e6-8ec0-0050568ef122","domain":"ROOT","created":"2016-09-09T01:44:25+0100","state":"Running","haenable":false,"zoneid":"c852110c-e1b5-4c8c-9e3d-f2a6e76b8fc0","zonename":"SBLAB-SW19-1","hostid":"fff7cdce-9d1d-408c-a37a-68e19113c092","hostname":"10.2.0.22","guestosid":"0372db46-6a9d-11e6-8ec0-0050568ef122","securitygroup":[],-->>
> "nic":[{"id":"fbbe345b-6cbd-495f-8e27-d180d782ccbe","networkid":"30002db2-be52-489f-8307-5c2fbcbea374","networkname":"JenkinsNet","netmask":"255.255.255.0","gateway":"10.5.1.254","ipaddress":"10.5.1.107","isolationuri":"vlan://12","broadcasturi":"vlan://12","traffictype":"Guest","type":"Shared","isdefault":true,"macaddress":"06:39:9c:01:0a:5b"}],
> <<--"hypervisor":"VMware","instancename":"i-15-93-VM","tags":[],"affinitygroup":[],"displayvm":true,"isdynamicallyscalable":false,"ostypeid":254}]}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to