[
https://issues.apache.org/jira/browse/CLOUDSTACK-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218119#comment-16218119
]
ASF GitHub Bot commented on CLOUDSTACK-10047:
---------------------------------------------
rhtyd commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch
fixes and improvements
URL: https://github.com/apache/cloudstack/pull/2293#discussion_r146758241
##########
File path: server/src/com/cloud/hypervisor/HypervisorGuruBase.java
##########
@@ -138,7 +143,24 @@ protected VirtualMachineTO
toVirtualMachineTO(VirtualMachineProfile vmProfile) {
if(vm.getType() == VirtualMachine.Type.NetScalerVm) {
nicProfile.setBroadcastType(BroadcastDomainType.Native);
}
- nics[i++] = toNicTO(nicProfile);
+ NicTO nicTo = toNicTO(nicProfile);
+ final NetworkVO network =
_networkDao.findByUuid(nicTo.getNetworkUuid());
+ if (network != null) {
+ final Map<NetworkOffering.Detail, String> details =
networkOfferingDetailsDao.getNtwkOffDetails(network.getNetworkOfferingId());
+ if (details != null) {
+ if
(!details.containsKey(NetworkOffering.Detail.PromiscuousMode)) {
Review comment:
Fixed. Thanks, good tip.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> DVSwitch improvements
> ---------------------
>
> Key: CLOUDSTACK-10047
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10047
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Rohit Yadav
> Assignee: Rohit Yadav
> Fix For: Future, 4.11.0.0
>
>
> All vlan trunking and list of vlan id/range, along with security policy
> settings on dvswitches.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
