[
https://issues.apache.org/jira/browse/CLOUDSTACK-10085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237218#comment-16237218
]
ASF GitHub Bot commented on CLOUDSTACK-10085:
---------------------------------------------
DaanHoogland commented on a change in pull request #2270: CLOUDSTACK-10085 :
Upload volume from local fails when global config max.account.seconday.storage
is set to -1
URL: https://github.com/apache/cloudstack/pull/2270#discussion_r148721255
##########
File path:
services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
##########
@@ -2809,7 +2808,7 @@ private synchronized void
checkSecondaryStorageResourceLimit(TemplateOrVolumePos
int accountDirSizeInGB = getSizeInGB(accountTemplateDirSize +
accountSnapshotDirSize + accountVolumeDirSize);
int defaultMaxAccountSecondaryStorageInGB =
Integer.parseInt(cmd.getDefaultMaxAccountSecondaryStorage());
- if ((accountDirSizeInGB + contentLengthInGB) >
defaultMaxAccountSecondaryStorageInGB) {
+ if (defaultMaxAccountSecondaryStorageInGB !=
Resource.RESOURCE_UNLIMITED && (accountDirSizeInGB + contentLengthInGB) >
defaultMaxAccountSecondaryStorageInGB) {
Review comment:
I do agree with @rafaelweingartner to some extend but I don't think we
should stop this fix because of it. Also the extend is that I agree that
extracting the if in a separate method but that we should always try to not
need any comments (including javadoc)
I am merging this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Upload volume from local fails when global config
> max.account.seconday.storage is set to -1
> -------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-10085
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10085
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Nitesh Sarda
> Priority: Major
>
> *ISSUE*
> Upload volume from local fails when global config
> max.account.seconday.storage is set to -1
> *STEPS TO REPRODUCE*
> * Download any volume on your local machine.
> * Change value of global configuration max.account.seconday.storage to -1.
> * Restart Management server.
> * Try to upload a volume from UI using "Upload from Local" option. Upload
> will fail.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
