[ https://issues.apache.org/jira/browse/CLOUDSTACK-9806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16253148#comment-16253148 ]
ASF GitHub Bot commented on CLOUDSTACK-9806: -------------------------------------------- rhtyd commented on a change in pull request #1981: CLOUDSTACK-9806: Nuage domain template selection per VPC URL: https://github.com/apache/cloudstack/pull/1981#discussion_r151065901 ########## File path: plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/ListNuageVspDomainTemplatesCmd.java ########## @@ -0,0 +1,118 @@ +// +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +// + +package com.cloud.api.commands; + +import com.cloud.api.response.NuageVspDomainTemplateResponse; +import com.cloud.exception.ConcurrentOperationException; +import com.cloud.exception.InsufficientCapacityException; +import com.cloud.exception.InvalidParameterValueException; +import com.cloud.exception.ResourceAllocationException; +import com.cloud.exception.ResourceUnavailableException; +import com.cloud.network.manager.NuageVspManager; +import com.cloud.utils.exception.CloudRuntimeException; +import org.apache.cloudstack.acl.RoleType; +import org.apache.cloudstack.api.APICommand; +import org.apache.cloudstack.api.ApiConstants; +import org.apache.cloudstack.api.ApiErrorCode; +import org.apache.cloudstack.api.BaseCmd; +import org.apache.cloudstack.api.BaseResponse; +import org.apache.cloudstack.api.Parameter; +import org.apache.cloudstack.api.ServerApiException; +import org.apache.cloudstack.api.response.DomainResponse; +import org.apache.cloudstack.api.response.ListResponse; +import org.apache.cloudstack.api.response.PhysicalNetworkResponse; +import org.apache.cloudstack.api.response.ZoneResponse; + +import javax.inject.Inject; +import java.util.List; Review comment: @sgoeminn newline here please, thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Nuage domain template selection per VPC > --------------------------------------- > > Key: CLOUDSTACK-9806 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9806 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: UI > Reporter: Sigert Goeminne > Assignee: Sigert Goeminne > > When deploying CloudStack with Nuage VSP (Virtualized Services > Plugin/Platform), the Cloud/Network Administrator has the ability to define > “Domain Templates” in the Nuage VSP Platform and reuse (and instantiate) > those when creating networks inside CloudStack. This allows for predefining > advanced networking topologies in the SDN platform, and integrate those > seamlessly within the CloudStack workflows, without the need of porting all > those SDN capabilities (e.g. GRT leaking, Advanced ACL’s, Service Chaining, > ...) into CloudStack. > Today this mechanism works via global settings and allows for one Nuage VSP > Domain Template to be specified per CloudStack Network type (Shared, > Isolated, VPC). This is fine for most deployments but it doesn’t leave room > for hybrid deployments in which different CloudStack networks need > individually differentiated SDN capabilities. Especially for VPC’s it would > be nice to have finer grained domain template control. > With the proposed new features, we add the ability to configure a domain > template per VPC, i.e. each VPC created in CloudStack can be configured with > a different domain template. We will make this option accessible through the > UI also, but applicable to Nuage supporting zones only. > [Design > Document|https://cwiki.apache.org/confluence/display/CLOUDSTACK/Nuage+domain+template+selection+per+VPC] -- This message was sent by Atlassian JIRA (v6.4.14#64029)