[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256853#comment-16256853
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10012:
---------------------------------------------

rafaelweingartner commented on a change in pull request #2329: 
CLOUDSTACK-10012: Jetty 9.4
URL: https://github.com/apache/cloudstack/pull/2329#discussion_r151663276
 
 

 ##########
 File path: client/src/org/apache/cloudstack/ServerDaemon.java
 ##########
 @@ -129,6 +126,7 @@ public void init(final DaemonContext context) {
             setKeystorePassword(properties.getProperty(KEYSTORE_PASSWORD));
             setWebAppLocation(properties.getProperty(WEBAPP_DIR));
             setAccessLogFile(properties.getProperty(ACCESS_LOG, "access.log"));
+            
setSessionTimeout(Integer.valueOf(properties.getProperty(SESSION_TIMEOUT, 
"10")));
 
 Review comment:
   @marcaurele you have a default value in the property file, which is 30, and 
here it is 10 (at line 85). Moreover, what about using the value of variable 
`sessionTimeout ` as the default values? The variable already starts with the 
default value anyways.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Migrate to Embedded Jetty based mgmt server
> -------------------------------------------
>
>                 Key: CLOUDSTACK-10012
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10012
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Rohit Yadav
>            Assignee: Rohit Yadav
>             Fix For: Future, 4.11.0.0
>
>
> CloudStack installation has huge dependency on distro provided tomcat, by 
> moving to embedded jetty (like we do use jetty for development) we can sync 
> how developers develop/test mgmt servers and users use it. In addition, it 
> will be easier to publish pkgs without depending on distro provided 
> dependencies.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to