[
https://issues.apache.org/jira/browse/CLOUDSTACK-10123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257906#comment-16257906
]
ASF GitHub Bot commented on CLOUDSTACK-10123:
---------------------------------------------
rhtyd closed pull request #2303: CLOUDSTACK-10123: any entity should use GMT
timestamp values
URL: https://github.com/apache/cloudstack/pull/2303
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
b/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
index f684cbfe881..ef333563621 100755
--- a/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
+++ b/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
@@ -2608,9 +2608,7 @@ protected void runInContext() {
s_logger.trace("VM Operation Thread Running");
try {
_workDao.cleanup(VmOpCleanupWait.value());
-
- // TODO. hard-coded to one hour after job has been completed
- final Date cutDate = new Date(new Date().getTime() - 3600000);
+ final Date cutDate = new
Date(DateUtil.currentGMTTime().getTime() - VmOpCleanupInterval.value() * 1000);
_workJobDao.expungeCompletedWorkJobs(cutDate);
} catch (final Exception e) {
s_logger.error("VM Operations failed due to ", e);
@@ -2980,7 +2978,7 @@ protected void runInContext() {
try {
scanStalledVMInTransitionStateOnDisconnectedHosts();
- final List<VMInstanceVO> instances =
_vmDao.findVMInTransition(new Date(new Date().getTime() -
AgentManager.Wait.value() * 1000), State.Starting, State.Stopping);
+ final List<VMInstanceVO> instances =
_vmDao.findVMInTransition(new Date(DateUtil.currentGMTTime().getTime() -
AgentManager.Wait.value() * 1000), State.Starting, State.Stopping);
for (final VMInstanceVO instance : instances) {
final State state = instance.getState();
if (state == State.Stopping) {
diff --git a/server/src/com/cloud/test/DatabaseConfig.java
b/server/src/com/cloud/test/DatabaseConfig.java
index f93692cb725..657eb4e4ce5 100644
--- a/server/src/com/cloud/test/DatabaseConfig.java
+++ b/server/src/com/cloud/test/DatabaseConfig.java
@@ -43,6 +43,7 @@
import com.cloud.storage.DiskOfferingVO;
import com.cloud.storage.Storage.ProvisioningType;
import com.cloud.storage.dao.DiskOfferingDaoImpl;
+import com.cloud.utils.DateUtil;
import com.cloud.utils.PropertiesUtil;
import com.cloud.utils.component.ComponentContext;
import com.cloud.utils.db.DB;
@@ -639,7 +640,7 @@ public void saveStoragePool() {
stmt.setLong(8, 0);
stmt.setString(9, hostAddress);
stmt.setString(10, hostPath);
- stmt.setDate(11, new Date(new java.util.Date().getTime()));
+ stmt.setDate(11, new Date(DateUtil.currentGMTTime().getTime()));
stmt.setLong(12, podId);
stmt.setString(13, Status.Up.toString());
stmt.setLong(14, clusterId);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> VmWork job gets deleted before the parent job had time to fetch its result
> --------------------------------------------------------------------------
>
> Key: CLOUDSTACK-10123
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10123
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Reporter: Marc-Aurèle Brothier
> Assignee: Marc-Aurèle Brothier
>
> Depending on the timezone you're running CS (before GMT timezones) you could
> experience that some jobs are marked as failed since the parent job got a
> null result despite its child job having successfully done the job. The child
> job got deleted by the {{CleanupTask}} ahead of time, due to a missing
> datetime conversion to GMT timezone.
> Jobs are failing with this message: {{Job failed with un-handled exception}}
> The fix intends to correct any datetime used in the code that should be using
> the GMT timezone instead of the local one since all DB datetime should be
> stored at GMT.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
