[
https://issues.apache.org/jira/browse/CLOUDSTACK-10161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272442#comment-16272442
]
ASF GitHub Bot commented on CLOUDSTACK-10161:
---------------------------------------------
rafaelweingartner commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven
wrapper
URL: https://github.com/apache/cloudstack/pull/2343#issuecomment-348136050
@khos2ow that is very interesting. They are indeed versioning this jar file.
I always had Spring projects as an example of quality; I find versioning
binary files a bit unusual though. However, if we zoom out the issue we see
that we already version binary files when versioning pictures (jpg, png, and
others) for instance. There are even ".class" files in our repo
(https://github.com/apache/cloudstack/blob/master/tools/appliance/convert/Convert.class).
I would be ok with this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Use maven wrapper
> -----------------
>
> Key: CLOUDSTACK-10161
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10161
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Khosrow Moossavi
> Priority: Minor
>
> The goal is to use Maven wrapper (https://github.com/takari/maven-wrapper) to
> decouple dependency to maven being installed on developer/ci machine.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
