[
https://issues.apache.org/jira/browse/CLOUDSTACK-8908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293640#comment-16293640
]
ASF GitHub Bot commented on CLOUDSTACK-8908:
--------------------------------------------
rhtyd closed pull request #2308: CLOUDSTACK-8908 After copying the template
charging for that template is stopped
URL: https://github.com/apache/cloudstack/pull/2308
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/engine/schema/src/com/cloud/usage/dao/UsageStorageDaoImpl.java
b/engine/schema/src/com/cloud/usage/dao/UsageStorageDaoImpl.java
index 45337b22e13..ad8ce59dba7 100644
--- a/engine/schema/src/com/cloud/usage/dao/UsageStorageDaoImpl.java
+++ b/engine/schema/src/com/cloud/usage/dao/UsageStorageDaoImpl.java
@@ -66,6 +66,7 @@ public UsageStorageDaoImpl() {
IdZoneSearch.and("id", IdZoneSearch.entity().getId(),
SearchCriteria.Op.EQ);
IdZoneSearch.and("type", IdZoneSearch.entity().getStorageType(),
SearchCriteria.Op.EQ);
IdZoneSearch.and("dcId", IdZoneSearch.entity().getZoneId(),
SearchCriteria.Op.EQ);
+ IdZoneSearch.and("deleted", IdZoneSearch.entity().getDeleted(),
SearchCriteria.Op.NULL);
IdZoneSearch.done();
}
@@ -85,6 +86,7 @@ public UsageStorageDaoImpl() {
sc.setParameters("id", id);
sc.setParameters("type", type);
sc.setParameters("dcId", dcId);
+ sc.setParameters("deleted", null);
return listBy(sc, null);
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> After copying the template charging for that template is stopped
> -----------------------------------------------------------------
>
> Key: CLOUDSTACK-8908
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8908
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Template, Usage
> Affects Versions: 4.5.2
> Reporter: subhash yedugundla
>
> [Repro Steps]
> Register a template in Zone 1 .
> Copy the template from Zone 1 to Zone 2 .
> Once copied, deleted the template from Zone 1.
> Check the charging of the template and found that charging of the template
> in Zone 2 stopped
> Sample data related to the issue
> mysql> select id,type,state,description,created from event where description
> like "%4186%" and type like "%template%";
> +---------+-----------------+-----------+-----------------------------------------------------------------------------------------+---------------------+
>
> | id | type | state | description | created |
> +---------+-----------------+-----------+-----------------------------------------------------------------------------------------+---------------------+
>
> | 1964466 | TEMPLATE.CREATE | Completed | Successfully completed creating
> template. Id: 4186 name: PerfTestVM2 | 2015-06-15 09:48:57 |
> | 2411011 | TEMPLATE.COPY | Scheduled | copying template: 4186 from zone: 3
> to zone: 1 | 2015-07-22 03:57:32 |
> | 2411012 | TEMPLATE.COPY | Started | copying template. copying template:
> 4186 from zone: 3 to zone: 1 | 2015-07-22 03:57:32 |
> | 2411458 | TEMPLATE.COPY | Completed | Successfully completed copying
> template. copying template: 4186 from zone: 3 to zone: 1 | 2015-07-22
> 04:47:08 |
> | 2412521 | TEMPLATE.DELETE | Scheduled | Deleting template 4186 | 2015-07-22
> 06:46:18 |
> | 2412522 | TEMPLATE.DELETE | Started | deleting template. Template Id: 4186
> | 2015-07-22 06:46:18 |
> | 2412523 | TEMPLATE.DELETE | Completed | Successfully completed deleting
> template. Template Id: 4186 | 2015-07-22 06:46:18 |
> +---------+-----------------+-----------+-----------------------------------------------------------------------------------------+---------------------+
>
> You can see that the template of zone3 is not removed.
> mysql> select * from template_zone_ref where template_id=4186;;
> +------+---------+-------------+---------------------+---------------------+---------------------+
>
> | id | zone_id | template_id | created | last_updated | removed |
> +------+---------+-------------+---------------------+---------------------+---------------------+
>
> | 3974 | 3 | 4186 | 2015-06-15 09:48:57 | 2015-06-15 09:48:57 | NULL |
> <=====Not removed
> | 4845 | 1 | 4186 | 2015-07-22 04:47:08 | 2015-07-22 04:47:08 | 2015-07-22
> 06:46:18 |
> +------+---------+-------------+---------------------+---------------------+---------------------+
>
> However, not only Zone1 but also the charging of the template of Zone3
> stopped.
> +---------+---------------------+---------------------+---------+----------------------------------------------------------+---------------+--------------------+----------+-------------+
>
> | id | start_date | end_date | zone_id | description | usage_display |
> raw_usage | usage_id | size |
> +---------+---------------------+---------------------+---------+----------------------------------------------------------+---------------+--------------------+----------+-------------+
>
> | 5998486 | 2015-06-14 15:00:00 | 2015-06-15 14:59:59 | 3 | Template Id:4186
> Size:14995087360VirtualSize:16106127360 | 4.808055 Hrs | 4.808055400848389 |
> 4186 | 14995087360 |
> =====================an abbreviation============================
> 4186 | 14995087360 |
> | 7834096 | 2015-07-19 15:00:00 | 2015-07-20 14:59:59 | 3 | Template Id:4186
> Size:14995087360VirtualSize:16106127360 | 24 Hrs | 24 | 4186 | 14995087360 |
> | 7889426 | 2015-07-20 15:00:00 | 2015-07-21 14:59:59 | 3 | Template Id:4186
> Size:14995087360VirtualSize:16106127360 | 24 Hrs | 24 | 4186 | 14995087360 |
> | 7945799 | 2015-07-21 15:00:00 | 2015-07-22 14:59:59 | 3 | Template Id:4186
> Size:14995087360VirtualSize:16106127360 | 15.771667 Hrs | 15.771666526794434
> | 4186 | 14995087360 |
> | 7945801 | 2015-07-21 15:00:00 | 2015-07-22 14:59:59 | 1 | Template Id:4186
> Size:14995087360VirtualSize:16106127360 | 1.986111 Hrs | 1.9861112833023071 |
> 4186 | 14995087360 |
> +---------+---------------------+---------------------+---------+----------------------------------------------------------+---------------+--------------------+----------+-------------+
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
