[
https://issues.apache.org/jira/browse/CLOUDSTACK-10102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16296648#comment-16296648
]
ASF GitHub Bot commented on CLOUDSTACK-10102:
---------------------------------------------
rafaelweingartner commented on a change in pull request #2281:
CLOUDSTACK-10102: New network type (L2)
URL: https://github.com/apache/cloudstack/pull/2281#discussion_r157728263
##########
File path: server/src/com/cloud/network/NetworkModelImpl.java
##########
@@ -1823,6 +1826,9 @@ public boolean isNetworkAvailableInDomain(long
networkId, long domainId) {
@Override
public Set<Long> getAvailableIps(Network network, String requestedIp) {
+ if (network.getCidr() == null) {
+ return null;
Review comment:
Instead of `null`, what about an empty set here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> New Network Type (L2)
> ---------------------
>
> Key: CLOUDSTACK-10102
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10102
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Nicolas Vazquez
> Assignee: Nicolas Vazquez
>
> Feature Specification:
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=74680920
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
