[
https://issues.apache.org/jira/browse/CLOUDSTACK-10013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299604#comment-16299604
]
ASF GitHub Bot commented on CLOUDSTACK-10013:
---------------------------------------------
marcaurele commented on a change in pull request #2211: CLOUDSTACK-10013:
Migrate systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158201994
##########
File path: python/lib/cloudutils/utilities.py
##########
@@ -216,8 +216,8 @@ def isKVMEnabled(self):
class serviceOpsRedhat7(serviceOps):
def isServiceRunning(self, servicename):
try:
- o = bash("systemctl status " + servicename)
- if "running" in o.getStdout() or "start" in o.getStdout() or
"Running" in o.getStdout():
+ o = bash("systemctl is-active " + servicename)
+ if "inactive" not in o.getStdout():
Review comment:
if statement can be simplified to: `return "inactive" not in o.getStdout()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Migrate to Debian9 systemvmtemplate
> -----------------------------------
>
> Key: CLOUDSTACK-10013
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10013
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Rohit Yadav
> Assignee: Rohit Yadav
> Fix For: Future, 4.11.0.0
>
>
> Migrate to debian9 based systemvmtemplate
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
