[
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302394#comment-16302394
]
ASF GitHub Bot commented on CLOUDSTACK-4757:
--------------------------------------------
rafaelweingartner commented on a change in pull request #2146: CLOUDSTACK-4757:
Support OVA files with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#discussion_r158581743
##########
File path: core/src/com/cloud/storage/template/OVAProcessor.java
##########
@@ -127,7 +158,53 @@ public long getTemplateVirtualSize(String templatePath,
String templateName) thr
}
return virtualSize;
} catch (Exception e) {
- String msg = "Unable to parse OVF XML document to get the virtual
disk size due to" + e;
+ String msg = "getTemplateVirtualSize: Unable to parse OVF XML
document " + templatePath + " to get the virtual disk " + templateName + " size
due to " + e;
+ s_logger.error(msg);
+ throw new InternalErrorException(msg);
+ }
+ }
+
+ public Pair<Long, Long> getDiskDetails(String ovfFilePath, String
diskName) throws InternalErrorException {
+ long virtualSize = 0;
+ long fileSize = 0;
+ String fileId = null;
+ try {
+ Document ovfDoc = null;
+ ovfDoc =
DocumentBuilderFactory.newInstance().newDocumentBuilder().parse(new
File(ovfFilePath));
+ NodeList disks = ovfDoc.getElementsByTagName("Disk");
+ NodeList files = ovfDoc.getElementsByTagName("File");
+ for (int j = 0; j < files.getLength(); j++) {
+ Element file = (Element)files.item(j);
+ if (file.getAttribute("ovf:href").equals(diskName)) {
+ fileSize = Long.parseLong(file.getAttribute("ovf:size"));
+ fileId = file.getAttribute("ovf:id");
+ break;
+ }
+ }
+ for (int i = 0; i < disks.getLength(); i++) {
Review comment:
This code is duplicated....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Support OVA files with multiple disks for templates
> ---------------------------------------------------
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Storage Controller
> Reporter: Likitha Shetty
> Assignee: Nicolas Vazquez
> Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of
> XenServer/XCP and KVM hypervisors since the files used for templates and
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates
> are in OVA format, which are archives that can contain a complete VM
> including multiple VMDKs and other files such as ISOs. And currently,
> Cloudstack only supports Template creation based on OVA files containing a
> single disk. If a user creates a template from a OVA file containing more
> than 1 disk and launches an instance using this template, only the first disk
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains
> multiple disks to a VM will result in only one VMDK to being attached to the
> VM.
> This behavior needs to be improved in VMWare to support OVA files with
> multiple disks for both uploaded volumes and templates. i.e. If a user
> creates a template from a OVA file containing more than 1 disk and launches
> an instance using this template, the first disk should be attached to the new
> instance as the ROOT disk and volumes should be created based on other VMDK
> disks in the OVA file and should be attached to the instance.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
