[
https://issues.apache.org/jira/browse/CLOUDSTACK-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302582#comment-16302582
]
ASF GitHub Bot commented on CLOUDSTACK-10126:
---------------------------------------------
nitin-maharana commented on a change in pull request #2368: CLOUDSTACK-10126:
Separate Subnet for SSVM and CPVM
URL: https://github.com/apache/cloudstack/pull/2368#discussion_r158589273
##########
File path: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -1110,6 +1122,14 @@ public Pod createPodIpRange(final
CreateManagementNetworkIpRangeCmd cmd) {
final String netmask = cmd.getNetmask();
final String startIp = cmd.getStartIp();
String endIp = cmd.getEndIp();
+ final boolean forSystemVms = cmd.isForSystemVms();
+ String vlan = cmd.getVlan();
+ if (!(vlan == null || "".equals(vlan) ||
vlan.startsWith(BroadcastDomainType.Vlan.scheme()))) {
Review comment:
Would be good if you replace the check with Strings.isNullOrEmpty(vlan).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Separate Subnet for CPVM and SSVM
> ---------------------------------
>
> Key: CLOUDSTACK-10126
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10126
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Affects Versions: 4.11.0.0
> Reporter: Nicolas Vazquez
> Assignee: Nicolas Vazquez
>
> Separate Management Subnet for CPVM and SSVM
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
