[
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302902#comment-16302902
]
ASF GitHub Bot commented on CLOUDSTACK-4757:
--------------------------------------------
nvazquez commented on a change in pull request #2146: CLOUDSTACK-4757: Support
OVA files with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#discussion_r158606488
##########
File path:
engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
##########
@@ -675,6 +695,18 @@ protected Void
createTemplateCallback(AsyncCallbackDispatcher<TemplateServiceImp
return null;
}
+ // Check if OVA contains additional data disks. If yes, create
Datadisk templates for each of the additional datadisk present in the OVA
+ if (template.getFormat().equals(ImageFormat.OVA)) {
+ if (!createDataDiskTemplates(template)) {
Review comment:
Thanks, actually there wasn't. I've now provided a way to return false in
case of checked exceptions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support OVA files with multiple disks for templates
> ---------------------------------------------------
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Storage Controller
> Reporter: Likitha Shetty
> Assignee: Nicolas Vazquez
> Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of
> XenServer/XCP and KVM hypervisors since the files used for templates and
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates
> are in OVA format, which are archives that can contain a complete VM
> including multiple VMDKs and other files such as ISOs. And currently,
> Cloudstack only supports Template creation based on OVA files containing a
> single disk. If a user creates a template from a OVA file containing more
> than 1 disk and launches an instance using this template, only the first disk
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains
> multiple disks to a VM will result in only one VMDK to being attached to the
> VM.
> This behavior needs to be improved in VMWare to support OVA files with
> multiple disks for both uploaded volumes and templates. i.e. If a user
> creates a template from a OVA file containing more than 1 disk and launches
> an instance using this template, the first disk should be attached to the new
> instance as the ROOT disk and volumes should be created based on other VMDK
> disks in the OVA file and should be attached to the instance.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
