[
https://issues.apache.org/jira/browse/CLOUDSTACK-10163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305372#comment-16305372
]
ASF GitHub Bot commented on CLOUDSTACK-10163:
---------------------------------------------
nvazquez commented on a change in pull request #2344: CLOUDSTACK-10163:
Component tests sanity
URL: https://github.com/apache/cloudstack/pull/2344#discussion_r158933656
##########
File path: test/integration/component/test_VirtualRouter_alerts.py
##########
@@ -47,6 +47,7 @@ def setUpClass(cls):
cls).getClsTestClient()
cls.api_client = cls.testClient.getApiClient()
cls.services = cls.testClient.getParsedTestDataConfig()
+ cls.hostConfig =
cls.config.__dict__["zones"][0].__dict__["pods"][0].__dict__["clusters"][0].__dict__["hosts"][0].__dict__
Review comment:
Is `cls.config` set here or should it be `cls.services`? Can we add basic
check for each dictionary key?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Component tests health check
> -----------------------------
>
> Key: CLOUDSTACK-10163
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10163
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Boris Stoyanov
> Attachments: kvm.tar.gz
>
>
> Attached is execution log of the kvm component test run, please fix as many
> tests as possible
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
