[
https://issues.apache.org/jira/browse/CLOUDSTACK-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310381#comment-16310381
]
ASF GitHub Bot commented on CLOUDSTACK-10126:
---------------------------------------------
DaanHoogland commented on a change in pull request #2368: CLOUDSTACK-10126:
Separate Subnet for SSVM and CPVM
URL: https://github.com/apache/cloudstack/pull/2368#discussion_r159542769
##########
File path: engine/schema/src/com/cloud/dc/dao/DataCenterDao.java
##########
@@ -35,7 +35,7 @@
String[] getNextAvailableMacAddressPair(long id, long mask);
- Pair<String, Long> allocatePrivateIpAddress(long id, long podId, long
instanceId, String reservationId);
+ Pair<Pair<String, Long>, Integer> allocatePrivateIpAddress(long id, long
podId, long instanceId, String reservationId, boolean forSystemVms);
Review comment:
can't we make a Pair<Pair<String, Long>, Integer> a
class allocationData extends Pair<Pair<String, Long>, Integer> {}
this is starting to read a bit like bad proza instead of poetry.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Separate Subnet for CPVM and SSVM
> ---------------------------------
>
> Key: CLOUDSTACK-10126
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10126
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Affects Versions: 4.11.0.0
> Reporter: Nicolas Vazquez
> Assignee: Nicolas Vazquez
>
> Separate Management Subnet for CPVM and SSVM
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
