[
https://issues.apache.org/jira/browse/CLOUDSTACK-10029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310794#comment-16310794
]
ASF GitHub Bot commented on CLOUDSTACK-10029:
---------------------------------------------
rhtyd closed pull request #2203: [CLOUDSTACK-10029] All private, public, and
guest interfaceses are marked as untagged ca…
URL: https://github.com/apache/cloudstack/pull/2203
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
index 2440e624ffa..c2a759b1e88 100644
---
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
+++
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
@@ -1695,8 +1695,7 @@ public ExecutionResult prepareNetworkElementCommand(final
IpAssocCommand cmd) {
if (nic.getBrName().equalsIgnoreCase(_linkLocalBridgeName)) {
broadcastUriAllocatedToVM.put("LinkLocal", nicPos);
} else {
- if (nic.getBrName().equalsIgnoreCase(_publicBridgeName) ||
nic.getBrName().equalsIgnoreCase(_privBridgeName) ||
-
nic.getBrName().equalsIgnoreCase(_guestBridgeName)) {
+ if (nic.getBrName() == null) {
broadcastUriAllocatedToVM.put(BroadcastDomainType.Vlan.toUri(Vlan.UNTAGGED).toString(),
nicPos);
} else {
final String broadcastUri =
getBroadcastUriFromBridge(nic.getBrName());
@@ -1749,8 +1748,7 @@ protected ExecutionResult
cleanupNetworkElementCommand(final IpAssocCommand cmd)
if (nic.getBrName().equalsIgnoreCase(_linkLocalBridgeName)) {
broadcastUriAllocatedToVM.put("LinkLocal", nicPos);
} else {
- if (nic.getBrName().equalsIgnoreCase(_publicBridgeName) ||
nic.getBrName().equalsIgnoreCase(_privBridgeName) ||
-
nic.getBrName().equalsIgnoreCase(_guestBridgeName)) {
+ if (nic.getBrName() == null) {
broadcastUriAllocatedToVM.put(BroadcastDomainType.Vlan.toUri(Vlan.UNTAGGED).toString(),
nicPos);
} else {
final String broadcastUri =
getBroadcastUriFromBridge(nic.getBrName());
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Virtual Router network interfaces are being constantly added by cloudstack.
> ---------------------------------------------------------------------------
>
> Key: CLOUDSTACK-10029
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10029
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: cloudstack-agent
> Affects Versions: 4.10.0.0
> Environment: Centos 7 x86_64
> Reporter: Konstantin Trushin
>
> When adding static nat eth interfaces are being added constantly to Virtual
> Router VM till they reach PCI slot limit of libvirt. This is caused by
> public, private and guest interfaces being marked as untagged and in HashMap
> and values are overwritten and cleanupNetworkElementCommand dosn't know nic
> number in VR VM and constantly adds eth interfaces.
> Below is some debugging output:
> 2017-07-25 10:47:21,054 ERROR [kvm.resource.LibvirtComputingResource]
> (agentRequest-Handler-2:null) (logid:57628c13) Exexutiong
> cleanupNetworkElementCommand
> 2017-07-25 10:47:21,054 DEBUG [kvm.resource.LibvirtConnection]
> (agentRequest-Handler-2:null) (logid:57628c13) Looking for libvirtd
> connection at: qemu:///system
> 2017-07-25 10:47:21,057 ERROR [kvm.resource.LibvirtComputingResource]
> (agentRequest-Handler-2:null) (logid:57628c13) HASH MAP DUMP:
> {vlan://untagged=0}
> 2017-07-25 10:47:21,057 ERROR [kvm.resource.LibvirtComputingResource]
> (agentRequest-Handler-2:null) (logid:57628c13) HASH MAP DUMP: {LinkLocal=1,
> vlan://untagged=0}
> 2017-07-25 10:47:21,057 ERROR [kvm.resource.LibvirtComputingResource]
> (agentRequest-Handler-2:null) (logid:57628c13) HASH MAP DUMP: {LinkLocal=1,
> vlan://untagged=2}
> 2017-07-25 10:47:21,057 ERROR [kvm.resource.LibvirtComputingResource]
> (agentRequest-Handler-2:null) (logid:57628c13) HASH MAP DUMP: {LinkLocal=1,
> vlan://untagged=3}
> 2017-07-25 10:47:21,058 ERROR [kvm.resource.LibvirtComputingResource]
> (agentRequest-Handler-2:null) (logid:57628c13) HASH MAP DUMP: {LinkLocal=1,
> vlan://untagged=4}
> 2017-07-25 10:47:21,058 ERROR [kvm.resource.LibvirtComputingResource]
> (agentRequest-Handler-2:null) (logid:57628c13) NIC pos 5
> 2017-07-25 10:47:21,058 ERROR [kvm.resource.LibvirtComputingResource]
> (agentRequest-Handler-2:null) (logid:57628c13) HASH MAP DUMP: {LinkLocal=1,
> vlan://untagged=4}
> 2017-07-25 10:47:21,058 ERROR [kvm.resource.LibvirtComputingResource]
> (agentRequest-Handler-2:null) (logid:57628c13) Lokking for BroadcastUri
> vlan://261
> 2017-07-25 10:47:21,058 ERROR [kvm.resource.LibvirtComputingResource]
> (agentRequest-Handler-2:null) (logid:57628c13) Plugging in VIF with MAC
> 1e:00:07:00:02:c8
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
