[
https://issues.apache.org/jira/browse/CLOUDSTACK-9025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313066#comment-16313066
]
ASF GitHub Bot commented on CLOUDSTACK-9025:
--------------------------------------------
DaanHoogland commented on a change in pull request #2315: A comprehensive
solution for CLOUDSTACK-9025 and CLOUDSTACK-10128.
URL: https://github.com/apache/cloudstack/pull/2315#discussion_r159871814
##########
File path:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/XenServerGuru.java
##########
@@ -167,35 +170,62 @@ public boolean trackVmHostChange() {
@Override
public Pair<Boolean, Long> getCommandHostDelegation(long hostId, Command
cmd) {
Review comment:
all the conditional returns compensate more then fully the complexity of the
nested conditionals, so i think the complexity grew. But of course you are
right and we should actually measure (lazy mode on - quickly)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to deploy VM instance from template if template spin from linked clone
> snapshot
> --------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-9025
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9025
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: XenServer
> Affects Versions: 4.5.2
> Environment: XenServer 6.5
> Reporter: Anshul Gangwar
> Assignee: Anshul Gangwar
> Priority: Critical
> Fix For: 4.6.0
>
>
> As default, CloudStack create linked clone snapshot for VM instance . When we
> take a snapshot for the VM, and create a template based on such snapshot,
> CloudStack only download incremental VHD as template file, as a result, the
> VM instance fail to deploy as it is incomplete.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
