[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313122#comment-16313122
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
---------------------------------------------

nvazquez commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass 
Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159878781
 
 

 ##########
 File path: agent/src/com/cloud/agent/Agent.java
 ##########
 @@ -600,6 +608,47 @@ protected void processRequest(final Request request, 
final Link link) {
         }
     }
 
+    private Answer 
setupDirectDownloadCertificate(SetupDirectDownloadCertificate cmd) {
+        String certificate = cmd.getCertificate();
+        String certificateName = cmd.getCertificateName();
+        s_logger.info("Importing certificate " + certificateName + " into 
keystore");
+
+        final File agentFile = 
PropertiesUtil.findConfigFile("agent.properties");
+        if (agentFile == null) {
+            return new Answer(cmd, false, "Failed to find agent.properties 
file");
+        }
+
+        final String keyStoreFile = agentFile.getParent() + "/" + 
KeyStoreUtils.defaultKeystoreFile;
 
 Review comment:
   Yes, I prefer using this java approach for those that can be done instead of 
using a script file. If you prefer I can refactor it to a script file

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Bypass Secondary Storage for KVM templates
> ------------------------------------------
>
>                 Key: CLOUDSTACK-10146
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>    Affects Versions: 4.11.0.0
>            Reporter: Nicolas Vazquez
>            Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to