[
https://issues.apache.org/jira/browse/CLOUDSTACK-10213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316015#comment-16316015
]
ASF GitHub Bot commented on CLOUDSTACK-10213:
---------------------------------------------
bwsw commented on a change in pull request #2389: CLOUDSTACK-10213: Allow
specify SSH key lengh
URL: https://github.com/apache/cloudstack/pull/2389#discussion_r160107085
##########
File path: server/src/com/cloud/server/ManagementServerImpl.java
##########
@@ -696,6 +696,8 @@
static final ConfigKey<Integer> vmPasswordLength = new
ConfigKey<Integer>("Advanced", Integer.class, "vm.password.length", "6",
"Specifies the length of a randomly generated password", false);
+ static final ConfigKey<Integer> sshKeyLength = new
ConfigKey<Integer>("Advanced", Integer.class, "ssh.key.length",
+ "2048", "User SSH key length (bit)", true,
ConfigKey.Scope.Account);
Review comment:
Might the description be more meaningful for average user, like "Specifies
minimal? amount of SSH key length permitted". Could you please take a look at
this. May be it can be improved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Allow specify SSH key lengh
> ---------------------------
>
> Key: CLOUDSTACK-10213
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10213
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Dmytro Shevchenko
>
> SSH keys generated by the ACS are only 1024 bit (RSA). The common standard is
> now at least 2048 bit.
> decompiled com.jcraft.jsch.KeyPair:
> {code:java}
> public static KeyPair genKeyPair(JSch jsch, int type) throws
> JSchException {
> return genKeyPair(jsch, type, 1024);
> }
> public static KeyPair genKeyPair(JSch jsch, int type, int key_size)
> throws JSchException {
> KeyPair kpair = null;
> ....
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
