[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320980#comment-16320980
 ] 

Daan Hoogland edited comment on CLOUDSTACK-10225 at 1/10/18 8:13 PM:
---------------------------------------------------------------------

not sure how to create a checklist in jira but here's a start

(+) join(final String delimiter, final Object... components) is a wrapper of 
the commons method with only a reverse of the parameters.
(+) join(final Iterable<? extends Object> iterable, final String delim) can be 
replaced withpout change
(+) isNotBlank() could be replaced by ! isBlank() except for a small semantic 
differnce; a string consisting of whitespace character like " \t\n" would be 
returning true instead of false


was (Author: dahn):
not sure how to create a checklist in jira but here's a start

(+) join() is a wrapper of the commons method with only a reverse of the 
parameters.
(+) isNotBlank() could be replaced by ! isBlank() except for a small semantic 
differnce; a string consisting of whitespace character like " \t\n" would be 
returning true instead of false

> Deprecate com.cloud.utils.StringUtils
> -------------------------------------
>
>                 Key: CLOUDSTACK-10225
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10225
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Wido den Hollander
>
> com.cloud.utils.StringUtils contains a lot of methods which can be deprecated 
> in favor of Apache Commons.
> We should try to use Apache Commons where possible and reduce our code 
> footprint.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to