[
https://issues.apache.org/jira/browse/CLOUDSTACK-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346505#comment-16346505
]
ASF GitHub Bot commented on CLOUDSTACK-10225:
---------------------------------------------
DaanHoogland commented on issue #2431: CLOUDSTACK-10225: Deprecate StringUtils
in favor of Apache Commons
URL: https://github.com/apache/cloudstack/pull/2431#issuecomment-361879495
I may have to revert this! as it turns out I overlooked that no regression
test report is included. I just saw a lot of green through flue stricken eyes
and merged.
As to the logging upgrade, @rafaelweingartner , whether the logging objects
are static or instance members doesn't change much for the fact that they need
to bee changed in every file. Also in case of a method rename (i.e. debug
become deBug (which is a much more accurate camelCase name come to think of
it)) We only need to change that in the proxy class and not all over our code.
Reducing surface area for external libraries is a best practice in
architecture. So is reducing the number of external libraries, which is of
course a force opposing the principle of not implementing what is already out
there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Deprecate com.cloud.utils.StringUtils
> -------------------------------------
>
> Key: CLOUDSTACK-10225
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10225
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Wido den Hollander
> Priority: Major
>
> com.cloud.utils.StringUtils contains a lot of methods which can be deprecated
> in favor of Apache Commons.
> We should try to use Apache Commons where possible and reduce our code
> footprint.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
