[
https://issues.apache.org/jira/browse/CLOUDSTACK-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355710#comment-16355710
]
ASF GitHub Bot commented on CLOUDSTACK-10268:
---------------------------------------------
khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package
script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-363834818
@rhtyd can you paste the command you ran that produced the screenshot you
attached?
If you don't do any _hacking_ around it and just pass the information and
let the script manages it, you should be getting `-SNAPSHOT` in the final
package name (without `--use-timestamp`). The sed/remove is to get the real
version without the snapshot, and it has been there in the script since long
time ago.
Our custom-versioned POM is `4.12.0.0-co-SNAPSHOT` and with:
Flags | Artifacts
------- | -----------
`--distribution centos7` |
`cloudstack-management-4.12.0.0-co.SNAPSHOT.el7.centos.x86_64.rpm`
`--distribution centos7 --use-timestamp` |
`cloudstack-management-4.12.0.0-co.1516920012.el7.centos.x86_64.rpm`
`--distribution centos7 --release 65` |
`cloudstack-management-4.12.0.0-co.SNAPSHOT65.el7.centos.x86_64.rpm`
`--distribution centos7 --use-timestamp --release 67` |
`cloudstack-management-4.12.0.0-co.151802073867.el7.centos.x86_64.rpm`
@rafaelweingartner completely forgot about Debian packages! ;) I'll look
into it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix and enhance package script
> ------------------------------
>
> Key: CLOUDSTACK-10268
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10268
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Packaging
> Reporter: Khosrow Moossavi
> Priority: Minor
> Fix For: 4.12
>
>
> - if there's a "branding" string in the POM version (e.g.
> `x.y.z.a-NAME[-SNAPSHOT]`),
> the branding name will be used in the final generated pacakge name such as
> following:
> `cloudstack-management-x.y.z.a-NAME.NUMBER.el7.centos.x86_64`
> - branding string can be overriden with newly added `-b, --brand` flag
> - new flag `-T, --use-timestamp` to use `timestamp` in final package name
> where POM
> version contains SNAPSHOT
> - fix long opts (they were broken)
> - tolerate and show a warning message for unrecognized flags
> - usage help reformat
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
