[
https://issues.apache.org/jira/browse/CLOUDSTACK-10218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355746#comment-16355746
]
ASF GitHub Bot commented on CLOUDSTACK-10218:
---------------------------------------------
DaanHoogland commented on a change in pull request #2445: CLOUDSTACK-10218: fix
for forced network update in a nuage network
URL: https://github.com/apache/cloudstack/pull/2445#discussion_r166688501
##########
File path:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
##########
@@ -470,14 +468,14 @@ public void reserve(NicProfile nic, Network network,
VirtualMachineProfile vm, D
HostVO nuageVspHost =
_nuageVspManager.getNuageVspHost(network.getPhysicalNetworkId());
VspNetwork vspNetwork =
_nuageVspEntityBuilder.buildVspNetwork(vm.getVirtualMachine().getDomainId(),
network);
- if (vm.getType() == VirtualMachine.Type.DomainRouter &&
vspNetwork.getVirtualRouterIp().equals("null")) {
+ boolean isUpgradeNetworkOffering = vm.getType() ==
VirtualMachine.Type.DomainRouter && vspNetwork.getVirtualRouterIp()
Review comment:
How about when more then one provider type is used in an install? Can we
guarantee this call is only called when? either the name
isUpgradeNetworkOffering is deceiving or the test is incomplete. Is this meant
to be a 'only if migrating from VR to nuage implementation' check?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> forced network update to a nuage network offering with vr fails with
> IllegalArgumentException
> ---------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-10218
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10218
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server, Network Controller
> Affects Versions: 4.11.0.0
> Environment: NuageVSP
> Reporter: Raf Smeets
> Assignee: Sigert Goeminne
> Priority: Major
> Attachments: configdrivemanagement-server.log
>
>
> a forced network update from a nuage network offering without vr to a nuage
> network offering with vr fails with java.lang.IllegalArgumentException
> Message: 'null' is not an IP string literal.
> It looks like this issue was introduced by recalculate broadcasturi
> introduced by the network migration PR. Cause:
> VspNetwork.getVirtualRouterIp() == "null" NuageVspElement:287
> Scenario to reproduce:
> update network id <networkid> networkofferingid <newnetworkofferingid>
> forced=true
> In failing test , existing network offering is one withoutVR,
> newnetworkoffering is one with VR as DNS requires VR.
> The exception reported in cloudstack is : java.lang.IllegalArgumentException
> Message: 'null' is not an IP string literal.
> Full cloudstack management server logs are attached.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
