[
https://issues.apache.org/jira/browse/CLOUDSTACK-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359546#comment-16359546
]
ASF subversion and git services commented on CLOUDSTACK-10243:
--------------------------------------------------------------
Commit ce67726c6d3db6e7db537e76da6217c5d5f4b10e in cloudstack's branch
refs/heads/master from [~widodh]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=ce67726 ]
CLOUDSTACK-10243: Do not use wait() on Python subprocess (#2421)
This might (and does block) in certain situations on the VR as
also explained in the Python documentation:
https://docs.python.org/2/library/subprocess.html#subprocess.Popen.wait
Warning This will deadlock when using stdout=PIPE and/or stderr=PIPE
and the child process generates enough output to a pipe such that
it blocks waiting for the OS pipe buffer to accept more data.
Use communicate() to avoid that.
Using the check_output function handles most of this for us and
also provides better error handling.
Signed-off-by: Wido den Hollander <[email protected]>
> Updating metadata might hang on VR on "ip rule show"
> ----------------------------------------------------
>
> Key: CLOUDSTACK-10243
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10243
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Virtual Router
> Affects Versions: 4.10.0.0, 4.11.0.0
> Environment: CloudStack 4.10 - Basic Networking
> Reporter: Wido den Hollander
> Assignee: Wido den Hollander
> Priority: Major
> Labels: basic-networking, python, virtual-router
> Fix For: Future
>
>
> On a CloudStack 4.10 setup running with Basic Networking we noticed VMs being
> in the "Starting" state.
> After investigating in the VR we show the "ip rule show" command run for ever
> and never end. This causes Python scripts to wait and thus never start the
> Instance.
> This seems to be a issue in CsHelper.py where it uses p.wait() which might
> block in certain situations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
