ASF GitHub Bot commented on CLOUDSTACK-10285:

ernjvr commented on a change in pull request #2452: CLOUDSTACK-10285: Fix db 
upgrade failure for users
URL: https://github.com/apache/cloudstack/pull/2452#discussion_r167792319

 File path: engine/schema/resources/META-INF/db/schema-41000to41100.sql
 @@ -546,3 +546,24 @@ ALTER TABLE cloud.ldap_trust_map ADD COLUMN account_id 
 ALTER TABLE cloud.ldap_trust_map DROP FOREIGN KEY fk_ldap_trust_map__domain_id;
 DROP INDEX uk_ldap_trust_map__domain_id ON cloud.ldap_trust_map;
 CREATE UNIQUE INDEX uk_ldap_trust_map__bind_location ON ldap_trust_map 
(domain_id, account_id);
+CREATE TABLE IF NOT EXISTS `cloud`.`netscaler_servicepackages` (
+  `id` bigint unsigned NOT NULL AUTO_INCREMENT COMMENT 'id',
+  `uuid` varchar(255) UNIQUE,
+  `name` varchar(255) UNIQUE COMMENT 'name of the service package',
+  `description` varchar(255) COMMENT 'description of the service package',
+  PRIMARY KEY  (`id`)
+CREATE TABLE IF NOT EXISTS `cloud`.`external_netscaler_controlcenter` (
+  `id` bigint unsigned NOT NULL AUTO_INCREMENT COMMENT 'id',
+  `uuid` varchar(255) UNIQUE,
+  `username` varchar(255) COMMENT 'username of the NCC',
+  `password` varchar(255) COMMENT 'password of NCC',
+  `ncc_ip` varchar(255) COMMENT 'IP of NCC Manager',
+  `num_retries` bigint unsigned NOT NULL default 2 COMMENT 'Number of retries 
in ncc for command failure',
+  PRIMARY KEY  (`id`)
+ALTER TABLE `cloud`.`sslcerts` ADD COLUMN `name` varchar(255) NULL default 
NULL COMMENT 'Name of the Certificate';
 Review comment:
   if pull request https://github.com/apache/cloudstack/pull/2449 gets approved 
and merged, we can make this add column statement idempotent afterwards

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> users face upgrade issues when upgrading to
> -------------------------------------------------------------
>                 Key: CLOUDSTACK-10285
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10285
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Rohit Yadav
>            Assignee: Rohit Yadav
>            Priority: Critical
>             Fix For:,
> users when upgrade to may face db related discrepancies due 
> to some PRs that got merged without moving their sql changes to 4.10->4.11 
> upgrade path. The users can run those missing sql statements 
> manually and then upgrade to, since a workaround like this is 
> possible this ticket is not marked a blocker. In, we'll move those 
> changes from> upgrade path to> upgrade 
> path. Ideally we should not be doing this, but this will fix issues for a 
> future user who may want to upgrade to or

This message was sent by Atlassian JIRA

Reply via email to