[
https://issues.apache.org/jira/browse/CLOUDSTACK-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366139#comment-16366139
]
ASF GitHub Bot commented on CLOUDSTACK-10278:
---------------------------------------------
rafaelweingartner commented on a change in pull request #2449: WIP
CLOUDSTACK-10278 idempotent column addition
URL: https://github.com/apache/cloudstack/pull/2449#discussion_r168579126
##########
File path: engine/schema/resources/META-INF/db/schema-41000to41100.sql
##########
@@ -19,8 +19,54 @@
-- Schema upgrade from 4.10.0.0 to 4.11.0.0
--;
+--;
+-- Stored procedure to do idempotent column add;
+--;
+DROP PROCEDURE IF EXISTS `cloud`.`IDEMPOTENT_ADD_COLUMN`;
Review comment:
I would also rather migrate to something like flywaydb too. However, I think
it would required quite more work than this one here. What do you think? I have
done this analysis before, but I was not having much time, and the discussion
died [1]. Maybe we could pick this topic up again?
[1] http://markmail.org/message/2dxtcnqx2euq5tl2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Adding a SQL table column is not Idempotent
> -------------------------------------------
>
> Key: CLOUDSTACK-10278
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10278
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Install and Setup
> Affects Versions: 4.10.0.0, 4.11.0.0
> Reporter: Ernie Janse van Rensburg
> Assignee: Ernie Janse van Rensburg
> Priority: Major
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> The SQL code to add a new column to a table in the
> META-INF/db/schema-41000to41100.sql script is not written in an idempotent
> way. When the upgrade is re-run, the code above causes a SQL error as
> reported on the user mailing list:
> ERROR [c.c.u.d.ScriptRunner] (main:null) (logid:)
> Error executing: ALTER TABLE cloud.network_offerings ADD COLUMN for_vpc
> INT(1) NOT NULL DEFAULT 0
> This is a more generic problem for every version due to to the fact that it
> is not idempotent
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
