[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374212#comment-16374212
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10284:
---------------------------------------------

rafaelweingartner closed pull request #2451: CLOUDSTACK-10284:Creating a 
snapshot from VM Snapshot generates error if hypervisor is not KVM.
URL: https://github.com/apache/cloudstack/pull/2451
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/ui/scripts/storage.js b/ui/scripts/storage.js
index 1cba7505491..e9b6138d0b6 100644
--- a/ui/scripts/storage.js
+++ b/ui/scripts/storage.js
@@ -2859,7 +2859,10 @@
         if (jsonObj.state == "Ready") {
             allowedActions.push("remove");
             allowedActions.push("revertToVMSnapshot");
-            allowedActions.push("takeSnapshot");
+
+            if (args && args.context && args.context.instances && 
args.context.instances[0].hypervisor && args.context.instances[0].hypervisor 
=== "KVM") {
+                allowedActions.push("takeSnapshot");
+            }
         }
 
         return allowedActions;


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Creating a snapshot from VM Snapshot generates error if hypervisor is not KVM.
> ------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-10284
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10284
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Nitesh Sarda
>            Priority: Major
>
> ISSUE
> Creating a snapshot from VM Snapshot generates error if hypervisor is not KVM.
> STEPS TO REPRODUCE
>  * Create a cloudstack setup with hypervisor other than KVM.
>  * Create an instance.
>  * Take Snapshot of that VM.
>  * Try to take volume snapshot from newly created VM snapshot.
>  * It will throw an error as hypervisor is not KVM.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to