ASF GitHub Bot commented on CLOUDSTACK-10246:

DaanHoogland commented on a change in pull request #2474: CLOUDSTACK-10246 Fix 
Host HA and VM HA issues
URL: https://github.com/apache/cloudstack/pull/2474#discussion_r171785409

 File path: 
 @@ -2587,7 +2589,13 @@ public boolean postStateTransitionEvent(final 
                 event == VirtualMachine.Event.FollowAgentPowerOnReport &&
                 newState == VirtualMachine.State.Running &&
                 isOutOfBandMigrated(opaque)) {
-            s_logger.debug("Virtual router " + vo.getInstanceName() + " is 
powered-on out-of-band");
+            /* Since vRouter appears to be powered-on OOB, make sure we can 
talk to router
+             * If we can't talk to it, we need to reboot it to get it managed 
+             * This is needed for example when a host agent goes down and 
comes back up,
+             * we would have done a failed HA event on the router and end up 
having our controlIP out-of-sync
+             */
+             s_logger.info("Router " + vo.getInstanceName() + " (ID:" + 
vo.getId() + ") is powered-on out-of-band, checking if can send 
CheckRouterCommand to router");
 Review comment:
   :+1: completely agree with this change, the ecosystem shouldn't rely on 
debug logging anyway. friendliness to the community dictates diligent testing 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> VM HA issues
> ------------
>                 Key: CLOUDSTACK-10246
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10246
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Management Server
>    Affects Versions:
>         Environment: My setup is CentOS 7 Management server with 3 CentOS 7 
> KVM HVs, NFS as primary and secondary storages.
>            Reporter: Nux
>            Priority: Major
> VM HA fails to kick in when one of the hypervisors goes down.
> It even fails to restart the system VMs which remain down along with the 
> instances until the affected HV comes back online.
> When I crash or power off the HV the system marks it in the hosts list as 
> "Alert" or "Disconnected" respectively. It should get changed to "Down" after 
> that, but this never happens.
> I have tried various combinations of setups (Adv, Basic), none succeeded.
> My instances use HA enabled offerings.
> Management server DEBUG logs here:
> [http://tmp.nux.ro/CW4-vmhafail-411rc1.txt]

This message was sent by Atlassian JIRA

Reply via email to