ASF GitHub Bot commented on CLOUDSTACK-10268:

khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package 
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-369966282
   @rhtyd @rafaelweingartner my goal in this PR was to be able to support
   - custom branding in POM version or provide it on the fly on CLI
   - concept of timestamp for SNAPSHOT versions (i.e. development cycles)
   in final artifacts (rpm, deb, systemvm-templates) and to achieve this I 
ended up modifying some files
   - `Version.java` to correctly handle `x.y.z.a-brand-[SNAPSHOT|timestamp]`
     - for MS to detect if VR needs to be upgraded
     - shown in `/etc/cloudstack-release`
   - `setnextversion.sh` to add `--no-commit` flag to change the version on the 
fly (from SNAPSHOT to `timestamp`, if specified) in packaging script to have 
consistency between deb, rpm versions and ACS version itself (which is read 
from final jar package version)

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Fix and enhance package script
> ------------------------------
>                 Key: CLOUDSTACK-10268
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10268
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Packaging
>            Reporter: Khosrow Moossavi
>            Priority: Minor
>             Fix For:
> * new flag `-T, --use-timestamp` to use `timestamp` when POM version contains 
>  ** in the final artifacts (jar) name
>  ** in the final package (rpm, deb) name
>  ** in `/etc/cloudstack-release` file of SystemVMs
>  ** in the Management Server > About dialog
>  * if there's a "branding" string in the POM version (e.g. 
> `x.y.z.a-NAME[-SNAPSHOT]`),  the branding name will be used in the final 
> generated pacakge name such as following:
>   ** `cloudstack-management-x.y.z.a-NAME.NUMBER.el7.centos.x86_64`
>  ** `cloudstack-management_x.y.z.a-NAME-NUMBER~xenial_all.deb`
>  * branding string can be overriden with newly added `-b, --brand` flag
>  * handle the new format version for VR version
>  * fix long opts (they were broken)
>  * tolerate and show a warning message for unrecognized flags
>  * usage help reformat

This message was sent by Atlassian JIRA

Reply via email to