[ https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387804#comment-16387804 ]
ASF GitHub Bot commented on CLOUDSTACK-10317: --------------------------------------------- rhtyd commented on a change in pull request #2476: CLOUDSTACK-10317: Fix SNAT rules for additional public nics URL: https://github.com/apache/cloudstack/pull/2476#discussion_r172520624 ########## File path: systemvm/debian/opt/cloud/bin/cs/CsAddress.py ########## @@ -388,7 +388,7 @@ def fw_router(self): self.fw.append(["mangle", "", "-A VPN_%s -j RETURN" % self.address['public_ip']]) self.fw.append(["nat", "", - "-A POSTROUTING -o eth2 -j SNAT --to-source %s" % self.address['public_ip']]) + "-A POSTROUTING -o %s -j SNAT --to-source %s" % (self.dev, self.address['public_ip'])]) Review comment: Thanks for confirming that we indeed need to set the device/interface in the rule @ustcweizhou. I think it makes sense to have the default packets routed to the default public snat ip. I'll let others comment on it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > In case of multiple-public ips, snat fails to work for addtional public > nics/network for guest traffic > ------------------------------------------------------------------------------------------------------ > > Key: CLOUDSTACK-10317 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Reporter: Rohit Yadav > Assignee: Rohit Yadav > Priority: Minor > Fix For: 4.12.0.0, 4.11.1.0 > > > If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed > correctly for traffic towards additional public nics. -- This message was sent by Atlassian JIRA (v7.6.3#76005)