[
https://issues.apache.org/jira/browse/CLOUDSTACK-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390936#comment-16390936
]
ASF GitHub Bot commented on CLOUDSTACK-10268:
---------------------------------------------
DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-371423375
The code in itself looks good @khos2ow, except that i am missing a link to
the db. How and where is the connection between CloudstackVersion and
VersionVO? Not sure if we need to worry to much but it is a reason for
extensive testing.
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix and enhance package script
> ------------------------------
>
> Key: CLOUDSTACK-10268
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10268
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Packaging
> Reporter: Khosrow Moossavi
> Priority: Minor
> Fix For: 4.12.0.0
>
>
> * new flag `-T, --use-timestamp` to use `timestamp` when POM version contains
> SNAPSHOT
> ** in the final artifacts (jar) name
> ** in the final package (rpm, deb) name
> ** in `/etc/cloudstack-release` file of SystemVMs
> ** in the Management Server > About dialog
> * if there's a "branding" string in the POM version (e.g.
> `x.y.z.a-NAME[-SNAPSHOT]`), the branding name will be used in the final
> generated pacakge name such as following:
> ** `cloudstack-management-x.y.z.a-NAME.NUMBER.el7.centos.x86_64`
> ** `cloudstack-management_x.y.z.a-NAME-NUMBER~xenial_all.deb`
> * branding string can be overriden with newly added `-b, --brand` flag
> * handle the new format version for VR version
> * fix long opts (they were broken)
> * tolerate and show a warning message for unrecognized flags
> * usage help reformat
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
