ASF GitHub Bot commented on CLOUDSTACK-10309:

Slair1 commented on a change in pull request #2473: CLOUDSTACK-10309 Add option 
on if to VM HA power-on a OOB-shut-off-VM
URL: https://github.com/apache/cloudstack/pull/2473#discussion_r174262477

 File path: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
 @@ -3853,7 +3856,7 @@ private void 
handlePowerOffReportWithNoPendingJobsOnVM(final VMInstanceVO vm) {
         case Stopped:
         case Migrating:
             s_logger.info("VM " + vm.getInstanceName() + " is at " + 
vm.getState() + " and we received a power-off report while there is no pending 
jobs on it");
-            if(vm.isHaEnabled() && vm.getState() == State.Running && 
vm.getHypervisorType() != HypervisorType.VMware && vm.getHypervisorType() != 
HypervisorType.Hyperv) {
+            if(vm.isHaEnabled() && vm.getState() == State.Running && 
HaVmRestartHostUp.value() && vm.getHypervisorType() != HypervisorType.VMware && 
vm.getHypervisorType() != HypervisorType.Hyperv) {
 Review comment:
   Yea, that sounds like a good idea, i am booked up here for a while, but it 
sounds like a good idea

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> VMs with HA enabled, power back on if shutdown from guest OS
> ------------------------------------------------------------
>                 Key: CLOUDSTACK-10309
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Management Server
>    Affects Versions: 4.9.0,
>         Environment: KVM
>            Reporter: Sean Lair
>            Priority: Minor
> When a user shuts down their VM from the guest OS (and VM HA is enabled), the 
> VM just powers itself back on.  Our environment is on KVM hosts.
> CloudStack does not know the difference between a VM failing or being 
> shutdown from within the guest OS.
> This is a major pain point for all our users - especially since they don't 
> pay for VMs when they are shutoff.  It is not intuitive for end-users to 
> understand why they can't shutdown VMs from within the guest OS.  Especially 
> when they all come from (non-cloudstack) VMware and Hyper-V environments 
> where this is not an issue.
> However, if a host fails, we need VM HA to still work.
> This Issue is being tied to a new PR that creates a configuration option 
> "ha.vm.restart.hostup".  With this option set to false, if CloudStack sees a 
> VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then 
> it won't power it back on.  The logic is that since the host is online, it 
> was most likely shutdown from the guest OS.
> For when a host actually fails, standard VM HA logic takes over and powers on 
> VMs (with VM HA enabled) if the host they were on fails.
> If that "ha.vm.restart.hostup" option is true (the default to match current 
> functionality), it works like always, and even in-guest shutdowns of VMs 
> causes CloudStack to power back on the VM.

This message was sent by Atlassian JIRA

Reply via email to