[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16399034#comment-16399034
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8855:
--------------------------------------------

DaanHoogland commented on a change in pull request #2387: CLOUDSTACK-8855 
Improve Error Message for Host Alert State and reconnect host API.
URL: https://github.com/apache/cloudstack/pull/2387#discussion_r174560563
 
 

 ##########
 File path: 
engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java
 ##########
 @@ -122,7 +122,6 @@
  **/
 public class AgentManagerImpl extends ManagerBase implements AgentManager, 
HandlerFactory, Configurable {
     protected static final Logger s_logger = 
Logger.getLogger(AgentManagerImpl.class);
-    protected static final Logger status_logger = 
Logger.getLogger(Status.class);
 
 Review comment:
   I agree it is a corner case and we can revert that if someone complains but 
it is an interface of the system, through the log configuration.
   I am fine with it, just wanted to be sure you realised. Also so we have a 
placeholder to easily find where to fix if someone complains

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improve Error Message for Host Alert State
> ------------------------------------------
>
>                 Key: CLOUDSTACK-8855
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8855
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>    Affects Versions: 4.6.0
>            Reporter: Bharat Kumar
>            Assignee: Bharat Kumar
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to