[
https://issues.apache.org/jira/browse/CLOUDSTACK-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407750#comment-16407750
]
ASF GitHub Bot commented on CLOUDSTACK-10331:
---------------------------------------------
rafaelweingartner closed pull request #2497: CLOUDSTACK-10331: Remove reference
to deleted script vm_snapshots.js
URL: https://github.com/apache/cloudstack/pull/2497
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/scripts/installer/windows/client.wxs
b/scripts/installer/windows/client.wxs
index ee09744fc7b..609d720a67e 100644
--- a/scripts/installer/windows/client.wxs
+++ b/scripts/installer/windows/client.wxs
@@ -437,9 +437,6 @@
<Component Id="cmpA9C076F1199B904BB57D1BC96A919814"
Guid="{91870ECD-F1AA-4B69-BCEC-9536BA94A0DC}">
<File Id="fil4CE0C842A4EF2E3C8322F88626C527E4"
KeyPath="yes" Source="!(wix.SourceClient)\scripts\templates.js" />
</Component>
- <Component Id="cmp429AD4BBE2ABA44D598EF5DC4482C2A4"
Guid="{29B7D8A7-D7FB-46C3-8808-4EBE6D848116}">
- <File Id="filDFD0025C484842DE376C881CFB81DC80"
KeyPath="yes" Source="!(wix.SourceClient)\scripts\vm_snapshots.js" />
- </Component>
<Component Id="cmpA7B70148FAF23BE9246895B84B8E76EE"
Guid="{06FB0332-62B7-4753-A0DA-B4906498D3A6}">
<File Id="fil560BA36DCB23B6FD4BCC65D8B062DAE6"
KeyPath="yes" Source="!(wix.SourceClient)\scripts\vpc.js" />
</Component>
@@ -1948,7 +1945,6 @@
<ComponentRef Id="cmp71D078D75E83971F80181453EA717D8B" />
<ComponentRef Id="cmpD605A23799365004C20E5DE80CA738F3" />
<ComponentRef Id="cmpA9C076F1199B904BB57D1BC96A919814" />
- <ComponentRef Id="cmp429AD4BBE2ABA44D598EF5DC4482C2A4" />
<ComponentRef Id="cmpA7B70148FAF23BE9246895B84B8E76EE" />
<ComponentRef Id="cmpA09401C5AC6539FD960D21860A2494EA" />
<ComponentRef Id="cmp4EF2024F5F084664B8B4EA6D2CFC68B7" />
diff --git a/ui/index.html b/ui/index.html
index b94e8e5ad01..5003f00b369 100644
--- a/ui/index.html
+++ b/ui/index.html
@@ -1881,7 +1881,6 @@ <h3><translate key="label.set.up.zone.type"/></h3>
<script type="text/javascript" src="scripts/network.js"></script>
<script type="text/javascript" src="scripts/domains.js"></script>
<script type="text/javascript" src="scripts/docs.js"></script>
- <script type="text/javascript" src="scripts/vm_snapshots.js"></script>
<script type="text/javascript"
src="scripts/ui-custom/projectSelect.js"></script>
<script type="text/javascript"
src="scripts/ui-custom/saml.js"></script>
<script type="text/javascript" src="scripts/ui-custom/ca.js"></script>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Error 404 for /client/scripts/vm_snapshots.js
> ---------------------------------------------
>
> Key: CLOUDSTACK-10331
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10331
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: UI
> Affects Versions: 4.10.0.0, 4.10.1.0, 4.11.0.0
> Reporter: Olivier Lemasle
> Assignee: Olivier Lemasle
> Priority: Minor
>
> CloudStack main page requests a script "client/scripts/vm_snapshots.js",
> which does exist since ACS 4.10, causing a HTTP 404 error.
> The script {{vm_snapshots.js}} was removed here:
> https://github.com/apache/cloudstack/pull/977/commits/a2428508e2969e89577ba29e4cf43ce28ba11704
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
