ASF GitHub Bot commented on CLOUDSTACK-10315:

lzh3636 opened a new pull request #2547: CLOUDSTACK-10315 Inconsistent 
debugging info in catch block
URL: https://github.com/apache/cloudstack/pull/2547
   ## Description
   <!--- Describe your changes in detail -->
   The description of the problem:
   I modified some stack traces information to those logging statements with 
the same log messages, make their stack trace consistent.
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to 
reproduce. -->
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the 
boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to 
   <!-- see how your change affects other areas of the code, etc. -->
   ## Checklist:
   <!--- Go over all the following points, and put an `x` in all the boxes that 
apply. -->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here 
to help! -->
   - [x] I have read the 
   - [x] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   - [ ] I have added tests to cover my changes.
   - [ ] All relevant new and existing integration tests have passed.
   - [x] A full integration testsuite with all test that can run on my 
environment has passed.
   <!-- The following will kick a packaging job, remove if as applicable -->
   @blueorangutan package

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Inconsistent debugging info in catch block
> ------------------------------------------
>                 Key: CLOUDSTACK-10315
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10315
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Zhenhao Li
>            Priority: Minor
>              Labels: easyfix
>         Attachments: image-2018-03-05-09-59-19-369.png, 
> image-2018-03-05-10-14-00-552.png, image-2018-03-05-10-14-25-802.png, 
> image-2018-03-26-17-45-44-489.png
> We found that some logging statements have same log message, but one of them 
> has stack trace info, the other one of them doesn't have. Maybe a possible 
> reason is that they are code clone, developers changed one of them(add stack 
> trace info) but forgot to change the other one. Here's the details of those 
> logging statements we found:
>  1.*"Moving on to the next host because " + h.toString() + " is unavailable"*,
> _com.cloud.hypervisor.ovm3.resources.Ovm3FenceBuilder.*fenceOff()*,_
> _com.cloud.ha.SimulatorFencer.*fenceOff()*_, 
> There are two identical log messages in these two places, the previous one 
> logged stack trace:
> !image-2018-03-26-17-45-44-489.png!
> But the latter one did not:
> !image-2018-03-05-09-59-19-369.png!
> We can see that they are in different type of catch block, but when checking 
> the logs they generated, maybe it's impossible to know the difference of them 
> without stack trace. So maybe the stack traces info should also be added here?
> 2.*"Network rule Conflict"*
> _org.apache.cloudstack.api.command.user.firewall.CreatePortForwardingRuleCmd.*create()*,_
> _org.apache.cloudstack.api.command.user.firewall.CreateFirewallRuleCmd.*create()*_
> The previous one has these two logging statements:
> s_logger.info("Network rule conflict: ", ex);
> s_logger.trace("Network Rule Conflict: ", ex);
> Comparing to the latter one which contains:
> s_logger.info("Network rule conflict: " + ex.getMessage());
> s_logger.trace("Network Rule Conflict: ", ex);
> Maybe it's better to have consistent exception handling here?

This message was sent by Atlassian JIRA

Reply via email to