ASF GitHub Bot commented on CLOUDSTACK-9114:

nitin-maharana commented on a change in pull request #2508: CLOUDSTACK-9114: 
Reduce VR downtime during network restart
URL: https://github.com/apache/cloudstack/pull/2508#discussion_r181347015

 File path: ui/scripts/network.js
 @@ -1100,11 +1100,23 @@
'checked'); //checked
args.$form.find('.form-item[rel=cleanup]').css('display', 'inline-block'); 
'checked'); //checked
'inline-block'); //shown
+                                        if 
(Boolean(args.context.networks[0].redundantrouter)) {
 Review comment:
   @rhtyd, As I understand, this functionality is not applicable to RVRs? For 
RVRs, the upgrade procedure is same as the old way. (Reboot the back-up and 
then reboot the master). But from the snapshots, I see, it creates a new router 
for each restart. (r-46-VM creates r-47-VM) and (r-45-VM creates r-48-VM). 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> restartnetwork with cleanup should not update/restart both routers at once
> --------------------------------------------------------------------------
>                 Key: CLOUDSTACK-9114
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9114
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Wei Zhou
>            Assignee: Wei Zhou
>            Priority: Major
> for now, restartnetwork with cleanup will stop both RVRs at first, then start 
> two  new RVRs.
> to reduce the downtime of network, we'd better restart the RVRs one by one.

This message was sent by Atlassian JIRA

Reply via email to