[
https://issues.apache.org/jira/browse/CLOUDSTACK-9473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597438#comment-16597438
]
ASF GitHub Bot commented on CLOUDSTACK-9473:
--------------------------------------------
DaanHoogland commented on a change in pull request #2829: CLOUDSTACK-9473:
storage pool capacity check when volume is resized or migrated
URL: https://github.com/apache/cloudstack/pull/2829#discussion_r214026700
##########
File path: server/src/com/cloud/storage/StorageManagerImpl.java
##########
@@ -1830,12 +1830,37 @@ public boolean storagePoolHasEnoughSpace(List<Volume>
volumes, StoragePool pool,
}
}
+ return checkPoolforSpace(pool, allocatedSizeWithTemplate,
totalAskingSize);
+ }
+
+ @Override
+ public boolean storagePoolHasEnoughSpaceForResize(StoragePool pool, long
currentSize, long newSiz) {
+ if (!checkUsagedSpace(pool)) {
+ return false;
+ }
+ if (s_logger.isDebugEnabled()) {
Review comment:
I think as a matter of principle we should alwas add the check. You never no
for what reason someone will alter the message. I like using String.format to
construct the message, btw, and then pass the single resulting string to the
logger
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Storage pool checker is ignored on resize and migrate volume.
> -------------------------------------------------------------
>
> Key: CLOUDSTACK-9473
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9473
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Storage Controller
> Affects Versions: 4.9.0
> Environment: * VMware vCenter 5.5U3/ESXi 5.0 U1
> * ACS 4.9 running on CentOS6.4
> Reporter: Boris Stoyanov
> Priority: Major
>
> *Description:*
> Storage pool checker is not being called on resize and migrate volume. This
> may lead to allocated percentage of storage above 100%.
> *Setup:*
> 1 VMware cluster with 2 Hosts.
> *Executed Steps:*
> # Applied the following global settings:
> #* storage.overprovisioning.factor = 1
> #* pool.storage.allocated.capacity.disablethreshold = 1
> #* pool.storage.capacity.disablethreshold = 1
> # Restarted management server
> # Executed Resize and migrate pool and Observed that Storage pool checker is
> not performed on resizeVolume and migrateVolume.
> *Result:*
> Root cause analysis shows storage pool checker is not called when doing
> migration and resizing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
