[
https://issues.apache.org/jira/browse/CLOUDSTACK-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700547#comment-16700547
]
ASF GitHub Bot commented on CLOUDSTACK-3049:
--------------------------------------------
bwsw commented on a change in pull request #3058: CLOUDSTACK-3049: update
dynamic role for an account
URL: https://github.com/apache/cloudstack/pull/3058#discussion_r236702016
##########
File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java
##########
@@ -1714,23 +1720,37 @@ public AccountVO updateAccount(UpdateAccountCmd cmd) {
// Check if user performing the action is allowed to modify this
account
checkAccess(getCurrentCallingAccount(),
_domainMgr.getDomain(account.getDomainId()));
- // check if the given account name is unique in this domain for
updating
- Account duplicateAcccount =
_accountDao.findActiveAccount(newAccountName, domainId);
- if (duplicateAcccount != null && duplicateAcccount.getId() !=
account.getId()) {
- throw new InvalidParameterValueException(
- "There already exists an account with the name:" +
newAccountName + " in the domain:" + domainId + " with existing account id:" +
duplicateAcccount.getId());
+ if(newAccountName != null) {
Review comment:
@rafaelweingartner
Hm, I don't think so or don't get the idea. I would like to distinguish
three situations:
1. newAccountName is not specified
2. newAccountName is specified but empty string -> exception 1
3. newAccountName is specified and not empty string -> action or exception
So, don't get how `StringUtils.isEmpty()` helps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> marvin-nose plugin causes other nose plugins to fail when not enabled
> ---------------------------------------------------------------------
>
> Key: CLOUDSTACK-3049
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3049
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Test Tools
> Affects Versions: 4.1.0, 4.2.0
> Reporter: Prasanna Santhanam
> Assignee: Prasanna Santhanam
> Priority: Major
> Fix For: 4.2.0
>
>
> enabled by default. Running regular nosetests with plugins other than marvin
> will fail because of this. Failure manifests itself as nose looking for the
> config file when using the marivn-nose plugin
> ~/workspace/cloudstack/incubator-cloudstack(branch:master*) ยป nosetests
> test.py
> Traceback (most recent call last):
> File "/usr/local/bin/nosetests", line 8, in <module>
> load_entry_point('nose==1.3.0', 'console_scripts', 'nosetests')()
> File "/Library/Python/2.7/site-packages/nose/core.py", line 118, in __init__
> **extra_args)
> File
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/main.py",
> line 94, in __init__
> self.parseArgs(argv)
> File "/Library/Python/2.7/site-packages/nose/core.py", line 135, in
> parseArgs
> self.config.configure(argv, doc=self.usage())
> File "/Library/Python/2.7/site-packages/nose/config.py", line 344, in
> configure
> self.plugins.configure(options, self)
> File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 284,
> in configure
> cfg(options, config)
> File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 99,
> in __call__
> return self.call(*arg, **kw)
> File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 167,
> in simple
> result = meth(*arg, **kw)
> File "/Library/Python/2.7/site-packages/marvin/marvinPlugin.py", line 61,
> in configure
> deploy = deployDataCenter.deployDataCenters(options.config)
> File "/Library/Python/2.7/site-packages/marvin/deployDataCenter.py", line
> 32, in __init__
> raise IOError("config file %s not found. please specify a valid config
> file"%cfgFile)
> IOError: config file ./datacenter.cfg not found. please specify a valid
> config file
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
