Copilot commented on code in PR #370: URL: https://github.com/apache/cloudstack-www/pull/370#discussion_r2382125618
########## source/generate_who.py: ########## @@ -95,10 +95,13 @@ def generate_markdown(pmc_members, committers): Board Minutes: https://whimsy.apache.org/board/minutes/CloudStack.html -""") +````mdx-code-block +import Releases from "@site/src/components/VP"; Review Comment: The import statement is incorrect. It should be `import VP from \"@site/src/components/VP\";` to match the component name and usage on line 101. ```suggestion import VP from "@site/src/components/VP"; ``` ########## src/components/VP/index.tsx: ########## @@ -0,0 +1,47 @@ +import React from "react"; + +const pmc_chair_quote = `"Earlier this year, I was selected by my fellow PMC members as the project’s VP. The main role of the VP is to report + quarterly to the Apache Software Foundation Board, + representing CloudStack and providing updates on the health + and status of the project. I am grateful for the opportunity + to serve as the CloudStack VP and to work with amazing people + from the community to continue making CloudStack an even + greater cloud orchestration platform!"` + +const pmc_chair_name = "Nicolás Vázquez" +const pmc_chair_picture = "/img/authors/nicolas.png" +const pmc_chair_githandle = "nvazquez" +const pmc_chair_linked = "nvazquezuy" + +const git_link = "https://github.com/"+pmc_chair_githandle +const linked_link = "https://www.linkedin.com/in/"+pmc_chair_linked + +export default function VP(): JSX.Element { + return <> + <div className="row"> + <div className="col col--3"> + +<img src={pmc_chair_picture} alt="{pmc_chair_name}" class="blog-image"/> Review Comment: The alt attribute contains literal braces instead of the variable value. It should be `alt={pmc_chair_name}` to properly interpolate the variable. ```suggestion <img src={pmc_chair_picture} alt={pmc_chair_name} class="blog-image"/> ``` ########## src/components/VP/index.tsx: ########## @@ -0,0 +1,47 @@ +import React from "react"; + +const pmc_chair_quote = `"Earlier this year, I was selected by my fellow PMC members as the project’s VP. The main role of the VP is to report + quarterly to the Apache Software Foundation Board, + representing CloudStack and providing updates on the health + and status of the project. I am grateful for the opportunity + to serve as the CloudStack VP and to work with amazing people + from the community to continue making CloudStack an even + greater cloud orchestration platform!"` + +const pmc_chair_name = "Nicolás Vázquez" +const pmc_chair_picture = "/img/authors/nicolas.png" +const pmc_chair_githandle = "nvazquez" +const pmc_chair_linked = "nvazquezuy" + +const git_link = "https://github.com/"+pmc_chair_githandle +const linked_link = "https://www.linkedin.com/in/"+pmc_chair_linked + +export default function VP(): JSX.Element { + return <> + <div className="row"> + <div className="col col--3"> + +<img src={pmc_chair_picture} alt="{pmc_chair_name}" class="blog-image"/> Review Comment: In React/JSX, HTML attributes should use camelCase. Change `class` to `className` for proper React syntax. ```suggestion <img src={pmc_chair_picture} alt="{pmc_chair_name}" className="blog-image"/> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
