[
https://issues.apache.org/jira/browse/EL-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521380
]
Henri Yandell commented on EL-8:
--------------------------------
We were in Bugzilla 3 years ago, which doesn't have the custom radio buttons
for granting a license etc. Btw, I know the 3 years ago is frustrating; that's
why Matt and I are poking at EL to try and fix some of these bugs, it
frustrates us that there have been no developers working on EL too.
IP with respect to patches is a bit of a grey area - at least in my
understanding. Simple patches are covered by not being copyrightable. Large
patches involve a request for a CLA (http://www.apache.org/licenses/icla.txt).
Ones in the middle are less defined.
With JIRA, a radio button was added so that people can indicate that 'Yes, a
copyright license to the ASF is desired'. That doesn't help for things in
Bugzilla, or for things that migrated into JIRA from Bugzilla as with this
issue, but now you've added another attachment that should sort out the issue.
I'm not sure what to do with your copyright statement though - I need to find
out whether I keep it in the source or add it to the NOTICE file.
'Fun' :)
----
Thanks for the new unit test - I confirm that the patch fails for that.
*scratches head*
> [el] Implementation of parseExpression does not implement spec
> --------------------------------------------------------------
>
> Key: EL-8
> URL: https://issues.apache.org/jira/browse/EL-8
> Project: Commons EL
> Issue Type: Bug
> Affects Versions: 1.0
> Environment: Operating System: All
> Platform: All
> Reporter: Jamie Taylor
> Fix For: 1.1
>
> Attachments: EL-8.patch, function-binding.txt,
> TestFunctionBinding.java, TestFunctionBinding.java
>
>
> The implementation of parseExpression in the EL expression evaluator does not
> conform to the JSP 2.0 specification. The javadoc for the fMapper argument
> states that
> "The ExpressionEvaluatormustnotholdontotheFunctionMapperreferenceafter
> returning fromparseExpression(). TheExpression object returned must invoke
> the same functions regardless of whether the mappings in the
> providedFunctionMapper instance change between calling
> ExpressionEvaluator.parseExpression() andExpression.evaluate()."
> The test case which I will attach clearly shows that this is not the case.
> Why hasn't anybody noticed this before, you may ask? I suspect that the
> current implementation of Tomcat never updates the bindings in its function
> mapper once one is constructed, since the functions are defined at web-app
> load time and can't be updated after that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
