[
https://issues.apache.org/jira/browse/LANG-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537841
]
Henri Yandell commented on LANG-362:
------------------------------------
General idea sounds good.
Here's a dump of thoughts - I'll try to look more tomorrow night, and have a
lot of time on Saturday.
* Ack, lots of new classes in text. I wonder if commons.lang.format would be a
tidier place.
* MetaFormat seems to be a crux interface, but the javadoc is tiny.
* reverse(Map) confused me - my first thought was 'HashMaps don't have order'.
Invert is a better name (and you use it in the javadoc).
* MultiFormat is a completely separate class - we should have a different JIRA
item for that. I feel that this has come up before, but maybe I'm thinking of
CompositeFormat. Needs a unit test focused on this, rather than the hook in in
MessageFormatExtension [assuming I'm right and this is a class that can be used
separately from the rest of it].
* MultiFormat.Builder - what does 'fluent interface' mean? And what are the
Builder classes for in this and NameKeyedMetaFormat, nothing uses them - until
I looked in the Tests and saw them using them - not a common pattern for Lang
and definitely something that if we keep it would need strong documentation.
* DefaultMetaFormatFactory - This makes me think there is a way of replacing it
with another. Is there? If not, is the Default necessary?
* Various 'non-Javadoc' bits in there. IDE spam?
[Sorry it's not a very deep look yet]
> Add ExtendedMessageFormat to org.apache.commons.lang.text
> ---------------------------------------------------------
>
> Key: LANG-362
> URL: https://issues.apache.org/jira/browse/LANG-362
> Project: Commons Lang
> Issue Type: New Feature
> Reporter: Matt Benson
> Assignee: Matt Benson
> Priority: Minor
> Fix For: 2.4
>
> Attachments: extendedMessageFormat.patch.txt
>
>
> Discussed on dev@ (
> http://mail-archives.apache.org/mod_mbox/commons-dev/200710.mbox/[EMAIL
> PROTECTED] ); adding here for tracking purposes and in case anyone has any
> serious objections to my implementation. Patch forthcoming...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
