[
https://issues.apache.org/jira/browse/COLLECTIONS-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538742
]
Brian Egge commented on COLLECTIONS-253:
----------------------------------------
I do like using the EasyMock library, but I'm not sure if there's enough of a
need for it in the Collections project. It would be another build dependecy
(obviously not a runtime dependency).
The patch looks good, but we'd have to modify the ant and maven build script to
include EasyMock.
> Generics version of PredicateUtils and the predicates it creates
> ----------------------------------------------------------------
>
> Key: COLLECTIONS-253
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-253
> Project: Commons Collections
> Issue Type: Improvement
> Components: Collection
> Affects Versions: Generics
> Environment: Mac OS X
> Reporter: Edwin Tellman
> Priority: Minor
> Fix For: Generics
>
> Attachments: predicates.tgz, predicates.txt
>
>
> I added generics to PredicateUtils and the predicates it creates
> (AndPredicate, AllPredicate, etc.). I also made use of variable argument
> arrays where it seemed appropriate.
> I modified TestPredicateUtils to use JUnit4 and EasyMock. I created new test
> classes for some of the predicates and migrated some of the existing tests
> from TestPredicateUtils to test classes for specific predicates. This
> allowed for the definition of some common tests and mock predicate creation
> routines in a base class.
> I added a unit test for the InvokerTransformer class.
> This patch depends on COLLECTIONS-247 as it uses JUnit4 and EasyMock.
> I believe there is some overlap between this patch and the patch attached to
> COLLECTIONS-110 by Hendrik Maryns yesterday.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
