[
https://issues.apache.org/jira/browse/VALIDATOR-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542321
]
Niall Pemberton commented on VALIDATOR-247:
-------------------------------------------
OK I've committed this. One difference from the patch was I retained the
"Integer" options for different credit card types and the
CreditCardValidator(int) constructor. Which should make migrating from the
existing CreditCardValidator to the new "routines" package version one easier.
> Move CreditCardValidator to routines package and refactor
> ---------------------------------------------------------
>
> Key: VALIDATOR-247
> URL: https://issues.apache.org/jira/browse/VALIDATOR-247
> Project: Commons Validator
> Issue Type: Task
> Components: Routines
> Reporter: Ben Speakmon
> Assignee: Niall Pemberton
> Fix For: 1.4
>
> Attachments: CreditCardValidator.java, CreditCardValidatorTest.java
>
>
> Having copied CreditCardValidator to routines, it now needs to be refactored
> to use CodeValidator/LuhnCheckDigit/etc. It might also make sense to break
> CreditCardType out into a separate 1.4-style typesafe enum so it can be
> easily converted to a real enum for Validator 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
