[
https://issues.apache.org/jira/browse/CHAIN-42?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Isaac Shabtay updated CHAIN-42:
-------------------------------
Attachment: patch-equals.txt
Proposed patch. Note that in none of the cases can "value" be null, so an NPE
shouldn't happen.
> Various scope mappers use incorrect equalization
> ------------------------------------------------
>
> Key: CHAIN-42
> URL: https://issues.apache.org/jira/browse/CHAIN-42
> Project: Commons Chain
> Issue Type: Bug
> Affects Versions: 1.1, 1.2
> Environment: All
> Reporter: Isaac Shabtay
> Attachments: patch-equals.txt
>
>
> The following classes:
> org.apache.commons.chain.web.portlet.PortletApplicationScopeMap
> org.apache.commons.chain.web.portlet.PortletRequestScopeMap
> org.apache.commons.chain.web.portlet.PortletSessionScopeMap
> org.apache.commons.chain.web.servlet.ServletApplicationScopeMap
> org.apache.commons.chain.web.servlet.ServletRequestScopeMap
> org.apache.commons.chain.web.servlet.ServletSessionScopeMap
> use the "==" for comparison in their containsValue(Object) methods. This is
> in contrary to java.util.Map's specification which mandates that the
> containsValue(v1) method returns true if and only if there exists a value 'v'
> in the map such that v1.equals(v).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
