Add Predicate that failed PredicatedCollection.validate to
IllegalArgumentException text
----------------------------------------------------------------------------------------
Key: COLLECTIONS-280
URL: https://issues.apache.org/jira/browse/COLLECTIONS-280
Project: Commons Collections
Issue Type: Improvement
Components: Collection
Affects Versions: 3.2
Environment: N/A
Reporter: Chris Lewis
Priority: Minor
In a project I'm working on at the moment, I decorate some of my sets with
multiple Predicates. In the event that validation fails, it would be nice to
know which predicate caused the failure.
I'd suggest changing the validate method in PredicatedCollection to:
protected void validate(Object object) {
if (predicate.evaluate(object) == false) {
throw new IllegalArgumentException("Cannot add Object '" + object +
"' - Predicate '" + predicate + "' rejected it");
}
}
Then, the user can provide a toString method with relevant information about
the Predicate and why it might cause the validation to fail if they choose.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
