[
https://issues.apache.org/jira/browse/POOL-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Thomas updated POOL-97:
----------------------------
Attachment: pool-97-markt-v1.patch
This patch fixes POOL-97, keeps the fix for POOL-56 and passes all the unit
tests. It does break the package private compatibility but I couldn't see an
easy way around that. The patch also removes some unused code and imports in
the two pool classes.
I have tested this with the latest Tomcat 5.5.x and the problem described in
http://issues.apache.org/bugzilla/show_bug.cgi?id=43552 (which I believe is a
symptom of this issue) is also fixed.
My aim was to stick to the commons-pool coding conventions but if this patch is
viewed as not doing things in the commons-pool way then I won't be offended if
you ask me to re-write it or if it is committed in a completely different form.
> EVICTION_TIMER is never cancelled.
> ----------------------------------
>
> Key: POOL-97
> URL: https://issues.apache.org/jira/browse/POOL-97
> Project: Commons Pool
> Issue Type: Bug
> Affects Versions: 1.3
> Reporter: Devendra Patil
> Fix For: 1.4
>
> Attachments: pool-97-markt-v1.patch, timer.patch
>
>
> The static EVICTION_TIMER (java.util.Timer) used in GenericObjectPool is
> never cancelled (even after closing the pool). The GenericObjectPool.close()
> method just cancels the _evictor (TimerTask). I agree this behaviour is ideal
> if EVICTION_TIMER is to be used across multiple pools.
> But, In my case, the resources (i.e. jars) are dynamically deployed and
> undeployed on remote grid-servers. If EVICTION_TIMER thread doesn't stop, the
> grid-servers fails to undeploy (i.e. delete) the jars. The grid-server
> doesn't restart during resource deployment/undeployment, so, setting
> EVICTION_TIMER to daemon doesn't help me.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
