[
https://issues.apache.org/jira/browse/MATH-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565253#action_12565253
]
Phil Steitz commented on MATH-188:
----------------------------------
The Fraction change is possible, since the fields are private, though I don't
see this as a big deal. I think the class is effectively immutable now.
The Complex change is unfortunately not backward compatible. We could
deprecate the *protected* fields and aim to remove and replace them later, but
we can't make them final now. The class as is is immutable, though subclasses
could add mutators.
> Make Complex and Fraction classes immutable and thus thread-safe
> ----------------------------------------------------------------
>
> Key: MATH-188
> URL: https://issues.apache.org/jira/browse/MATH-188
> Project: Commons Math
> Issue Type: Improvement
> Reporter: Sebb
>
> There are many classes with instance fields that could be made final.
> Two in particular seem like ideal candidates:
> Complex - fields: real, imaginary
> Fraction - fields: numerator, denominator (the private reduce() method also
> needs to be inlined)
> As far as I can tell, making the above changes makes the classes immutable
> and therefore threadsafe.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
