[
https://issues.apache.org/jira/browse/LANG-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565452#action_12565452
]
mbenson edited comment on LANG-362 at 2/25/08 11:54 AM:
------------------------------------------------------------
If we proceed from the supposition that full dynamic toPattern() support is
required, it seems to me that creating a different interface to convert Formats
to/from strings is redundant, and it was this line of thinking that led me to
what I saw as an epiphany: that that's what a Format is.
HOWEVER, I must admit that your reasoning about why toPattern() is far less
important - once we have established that EMF obviates the need for altering
the formats at runtime - was fairly convincing. The main object now being
trying to achieve a compromise, would you agree that if setFormats(),
setFormat(), and setFormatByArgumentIndex() can all be overridden to throw
UnsupportedOperationException? Explicitly blocking these would, IMO, make
returning the original pattern unchanged from toPattern() perfectly fine. Then
we could go with the EMF2 approach. Are we getting closer to consensus?
was (Author: mbenson):
If we proceed from the supposition that full dynamic toPattern() support is
required, it seems to me that creating a different interface to convert Formats
to/from strings is redundant, and it was this line of thinking that led me to
what I saw as an epiphany: that that's what a Format is.
HOWEVER, I must admit that your reasoning about why toPattern() is far less
important--once we have established that EMF obviates the need for altering the
formats at runtime--was fairly convincing. The main object now being trying to
achieve a compromise, would you agree that if setFormats(), setFormat(), and
setFormatByArgumentIndex() can all be overridden to throw
UnsupportedOperationException? Explicitly blocking these would, IMO, make
returning the original pattern unchanged from toPattern() perfectly fine. Then
we could go with the EMF2 approach. Are we getting closer to consensus?
> Add ExtendedMessageFormat to org.apache.commons.lang.text
> ---------------------------------------------------------
>
> Key: LANG-362
> URL: https://issues.apache.org/jira/browse/LANG-362
> Project: Commons Lang
> Issue Type: New Feature
> Reporter: Matt Benson
> Assignee: Matt Benson
> Priority: Minor
> Fix For: 2.4
>
> Attachments: DateFormatFactory.java, extendedMessageFormat.patch.txt,
> extendedMessageFormat.patch.txt, ExtendedMessageFormat2.java,
> FormatFactory.java
>
>
> Discussed on dev@ (
> http://mail-archives.apache.org/mod_mbox/commons-dev/200710.mbox/[EMAIL
> PROTECTED] ); adding here for tracking purposes and in case anyone has any
> serious objections to my implementation. Patch forthcoming...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
