[
https://issues.apache.org/jira/browse/NET-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576791#action_12576791
]
Sebb commented on NET-195:
--------------------------
Given that the method attempts synchronisation, it is presumably intended to be
called from multiple threads.
However, the synchronisation is broken, so needs to be fixed.
> Ntpv3Impl attempts double-checked locking
> -----------------------------------------
>
> Key: NET-195
> URL: https://issues.apache.org/jira/browse/NET-195
> Project: Commons Net
> Issue Type: Bug
> Reporter: Sebb
> Priority: Minor
>
> The NtpV3Impl#getDatagramPacket() method implements double-checked locking,
> which is known not to work.
> The initial "if (dp == null)" condition should be removed; once this is done,
> the synch block could be removed and the method synchronized instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
