[ 
https://issues.apache.org/jira/browse/COLLECTIONS-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580237#action_12580237
 ] 

Matt Benson commented on COLLECTIONS-227:
-----------------------------------------

This patch suffers from several shortcomings:
- inverseSortedBidiMap is not implemented other than to return null
- comparator() was pretty much nonsensical, simple enough to return 
ComparatorUtils.NATURAL_COMPARATOR, however
- the implementations for headMap, tailMap, and subMap don't appear to continue 
to be backed by the originating map, contrary to the contract from SortedMap

These will require quite a bit of work, possibly cloning some inner classes 
from DualTreeBidiMap.  It's probably more responsible to push this to 3.4, but 
I'll give it a little time.

> TreeBidiMap should implement SortedBidiMap
> ------------------------------------------
>
>                 Key: COLLECTIONS-227
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-227
>             Project: Commons Collections
>          Issue Type: Improvement
>          Components: BidiMap
>            Reporter: Stephen Colebourne
>            Priority: Trivial
>             Fix For: 3.3
>
>         Attachments: TreeBidiMap.pat
>
>
> TreeBidiMap should implement SortedBidiMap as it fulfils the criteria. (Note 
> that at present, the ordering in TreeBidiMap is limited to natural ordering)
> This issue needs a patch to actually go anywhere.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to